forked from microsoft/TypeScript
-
Notifications
You must be signed in to change notification settings - Fork 14
Es private methods and accessors simplify emit #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dragomirtitian
merged 2 commits into
es-private-methods-and-accessors
from
es-private-methods-and-accessors-simplify-emit
Mar 18, 2021
Merged
Es private methods and accessors simplify emit #56
dragomirtitian
merged 2 commits into
es-private-methods-and-accessors
from
es-private-methods-and-accessors-simplify-emit
Mar 18, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and modified the existing helpers for get and set fields to do the same job.
e605e6f
to
6c19c52
Compare
mkubilayk
reviewed
Mar 18, 2021
46573de
to
eed5e6b
Compare
mkubilayk
reviewed
Mar 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Transform code looks good. I left some comments but they are all cosmetic changes and mostly optional. Will take a look at fixtures now.
eed5e6b
to
a3fdc4b
Compare
mkubilayk
approved these changes
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.