Skip to content

Add case to capture enum subtype reduction (addresses #35867) #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

lawrencecraft
Copy link

Issue number of the reported bug or feature request: microsoft#35867

Describe your changes

I've added tests to prevent regressions for this bug. I created a few scenarios that could trigger this.

Testing performed

n/a - tests are the only change

@lawrencecraft lawrencecraft force-pushed the tests-for-35867-enum branch from d3076fa to c710b96 Compare June 16, 2022 09:37
Signed-off-by: Lawrence Craft <[email protected]>
@lawrencecraft lawrencecraft force-pushed the tests-for-35867-enum branch from 9945901 to 5126ba9 Compare June 16, 2022 09:40
Copy link

@acutmore acutmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Very decent test coverage. Thanks @lawrencecraft

@acutmore acutmore merged commit bdf99c4 into bloomberg:oss-hackathon-35867 Jun 16, 2022
@acutmore
Copy link

acutmore commented Jun 16, 2022

We'll now wait for @lawrencecraft to be adding as a maintainer so he can raise the PR himself for full attribution 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants