-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat(table): remove deprecated slot names, introduce new slot names #3866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #3866 +/- ##
========================================
- Coverage 99.3% 99.3% -0.01%
========================================
Files 233 233
Lines 4484 4473 -11
Branches 1270 1266 -4
========================================
- Hits 4453 4442 -11
Misses 25 25
Partials 6 6
Continue to review full report at Codecov.
|
Created an upstream issue at vuejs/vue#10390 regarding new |
Describe the PR
This PR removes the deprecations from the
<b-table>
and<b-table-simple>
components.Users should now be using slots
cell[field]
instead offield
,head[field]
instead ofHEAD_field
, andfoot[field]
instead ofFOOT_field
. Noe these new slot names are different than teh ones introduced in 2.0.0-rc.28.The changes are needed due to the new Vue
v-slot
syntaxPR checklist
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
dev
branch, not themaster
branch[...] (fixes #xxx[,#xxx])
, where "xxx" is the issue number)fix(alert): not alerting during SSR render
,docs(badge): update pill examples, fix typos
,chore: fix typo in README
, etc). This is very important, as theCHANGELOG
is generated from these messages.If new features/enhancement/fixes are added or changed:
package.json
for slot and event changes)If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: