This repository was archived by the owner on Jan 19, 2019. It is now read-only.
Chore: Update typescript-eslint-parser and typescript #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apologies for the conflicts here, @macklinu - I wanted to leave this one until last within the current batch. I am going to cut a release now, and then we can see where we are at once the build rereuns for this. |
macklinu
force-pushed
the
update-parser
branch
2 times, most recently
from
89b4512 to
11c113f
Compare
|
Just rebased and force pushed up - tests were passing locally for me. Made sure to lock the TypeScript version to 2.7.x, since typescript-eslint-parser ^14 does not officially support TypeScript 2.8. |
|
@macklinu Would you mind bumping this again now that the parser supports 2.8? |
|
@JamesHenry just rebased against master and pushed up the update 👍 |
|
Awesome, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates typescript-eslint-parser and typescript to the latest versions.
The only breaking change in typescript-eslint-parser I could find was in eslint/typescript-eslint-parser#412, which added the
TSEmptyBodytypes. Some of theadjacent-overload-signaturestests were failing, but adding theTSEmptyBodynode types to the rule fixed those tests.If there is something else to be aware of in this update or if there's a better commit message name, please let me know! 😄