Use gatsby-remark-autolink-headers to get improved heading ids #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes formatted text (e.g. inline code) being rendered as “[object Object]” (#84), and multiple text children (e.g. `new Pool([config: object])`, for some reason) being rendered with commas. Also now compatible with GitHub! Can be used to add link icons beside each heading later by removing `icon: false` from its configuration (but needs additional CSS).
|
Hey! A preview of the changes is deployed on netlify to take a look at! :) Built with commit 81d38cc https://deploy-preview-85--hopeful-clarke-f36d36.netlify.app |
|
Howdy - when I test the deployed page https://deploy-preview-85--hopeful-clarke-f36d36.netlify.app some of the side bar links on the right nav don't work for me anymore:
Any idea why some links aren't working on some of these sections for me now? |
|
I never noticed that sidebar :D Fixing, thanks! |
Fixes right sidebar for id changes after introduction of gatsby-remark-autolink-headers.
|
Beautiful! You're amazing. Thank you! ❤️ |
|
also... @charmander do you want merge privileges here? You have 'em on the main repo - makes sense to have 'em here too! |
|
I already have them, but I’ll take that as a hint to merge more of the uncontroversial docs PRs :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes formatted text (e.g. inline code) being rendered as “[object Object]” (#84), and multiple text children (e.g.
new Pool([config: object]), for some reason) being rendered with commas. Also now compatible with GitHub!Can be used to add link icons beside each heading later by removing
icon: falsefrom its configuration (but needs additional CSS).