Skip to content

Stop using const enums, as it breaks environments with babel and isolatedModules #2481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
bart-opplane opened this issue Feb 25, 2021 · 1 comment
Open

Stop using const enums, as it breaks environments with babel and isolatedModules #2481

bart-opplane opened this issue Feb 25, 2021 · 1 comment

Comments

@bart-opplane
Copy link

Const enums (like the ones in https://github.com/brianc/node-postgres/blob/master/packages/pg-protocol/src/messages.ts) are a feature specific to Typescript projects built with tsc compiler. Builds that do not use tsc and only compile explicitly imported files need the --isolatedModules flag enabled, which does not suppport const enums

Please replace const enums with normal enums.
@bart-opplane bart-opplane mentioned this issue Feb 25, 2021
Closed
@bart-opplane
Copy link
Author

#2473

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bart-opplane