TypeError: Cannot set property message of #<_ErrorEvent> which has only a getter on connection timeout with @neondatabase/serverless library

[andyjy]

Using @neondatabase/serverless (which extends pg Client and Pool) I encountered the following fatal error thrown within pg-pool:

TypeError: Cannot set property message of #<_ErrorEvent> which has only a getter

This occurs since the exception passed to the connection callback for Pool is of type ErrorEvent (from the Cloudflare Workers websocket implementation) instead of Error, and ErrorEvent has a readonly message property that can't be overwritten.

While a fix could be written into @neondatabase/serverless to only pass an Error as pg-pool currently expects, it seemed more useful to address this here in pg-pool to be tolerant of different types for the exception in general, while preserving the original error message instead of overwriting it as per the current implementation.

Here is the diff that solved my problem:

diff --git a/node_modules/pg-pool/index.js b/node_modules/pg-pool/index.js
index 94004e0..52c595a 100644
--- a/node_modules/pg-pool/index.js
+++ b/node_modules/pg-pool/index.js
@@ -244,7 +244,7 @@ class Pool extends EventEmitter {
         // remove the dead client from our list of clients
         this._clients = this._clients.filter((c) => c !== client)
         if (timeoutHit) {
-          err.message = 'Connection terminated due to connection timeout'
+          err = new Error('Connection terminated due to connection timeout', { cause: err });
         }
 
         // this client won’t be released, so move on immediately

This issue body was partially generated by patch-package.