client.query breaks if null is passed into query

[davidgbe]

This isn't too much of a concern, but if the query param is passed into client.query as null, node crashes and the callback is never made. For instance:

var query = null
client.query(query, function(err, res) {
  if(err) { } //handle err
}) 

Produces:

/Users/dbell/work/curious/node_modules/pg/lib/client.js:323
  var query = (typeof config.submit == 'function') ? config :
                            ^
TypeError: Cannot read property 'submit' of null
    at Client.query (/Users/dbell/work/curious/node_modules/pg/lib/client.js:323:29)

[joskuijpers]

I had this too, just a day ago. I passed undefined.

We could just assert(query != null) as passing such value is a developer error.

Before you pass a query, you should check it is a valid one. Either by having no code-path that creates an undefined/null query, or just placing some if statement or such.

[brianc]

Yeah an assert would probably be good here to give a better indication of what exactly is going on.