Error Handling for null Params to Client.prototype.query() #1651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. |
|
why not simply check config falsyness ? |
|
Type errors tend to throw synchronously. I don’t see a reason to break that pattern for if (config == null) {
throw new TypeError('Query was null or undefined')
} |
patrickrgaffney
force-pushed
the
null-queries
branch
from
fa035df to
d11926b
Compare
|
Just made the changes and |
charmander
approved these changes
Jun 19, 2018
|
|
||
| test('handles errors', function () { | ||
| var client = helper.client() | ||
| var error = new Error('Client was passed a null or undefined query') |
There was a problem hiding this comment.
Is this variable unused?
There was a problem hiding this comment.
Yep, must have missed it when I fixed the tests. I'll push up again.
patrickrgaffney
force-pushed
the
null-queries
branch
from
d11926b to
1b19a4d
Compare
|
Thanks for this! sorry for the delay. Will push a new version soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add's a basic assertion to
Client.prototype.query()ensuring thatconfigis notnullorundefined. This fixes #628 — which was closed, but the behavior described in that issue lives on. I added some additional tests around the new logic.I ran into the same problem described in that issue — some bad destructing logic on my end led to
configbeingundefinedwhen callingquery(). That results in aTypeErrorwhen thetypeof config.submit === 'function'assertion is executed. The behavior is still basically the same, except that the error is detected, described, and sent to the userscallbackorPromise.rejected.