Skip to content

Stream end #1607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

Stream end #1607

wants to merge 6 commits into from

Conversation

Elexy
Copy link
Contributor

@Elexy Elexy commented Apr 4, 2018

No description provided.

@Elexy Elexy closed this Apr 4, 2018
@Vratislav
Copy link
Contributor

@Elexy hello, this is something that I was thinking of adding because our connections were not closing correctly when running against postgres on Azure. Why have you closed it?

@Elexy
Copy link
Contributor Author

Elexy commented Apr 4, 2018

The tests aren't passing: https://travis-ci.org/brianc/node-postgres/jobs/362160404
It's a bit beyond me why.

@Elexy Elexy reopened this Apr 4, 2018
@Vratislav
Copy link
Contributor

@Elexy I will look into it.

@Vratislav
Copy link
Contributor

@Elexy I've submitted new PR with passing tests and a proper write-up: #1608

If you are ok with it, you can close this PR in favor of the one mentioned above.

Thanks for pointing the fix into right direction. 👍

@charmander charmander closed this Apr 4, 2018
@Elexy Elexy deleted the stream-end branch April 5, 2018 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Elexy @Vratislav @charmander