Add PostgreSQL 10 to CI #1947
Merged
Add PostgreSQL 10 to CI #1947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for not seeing this - if you rebase on master does this build cleanly now? Would be happy to merge when it does! |
charmander
force-pushed
the
ci-postgresql-10
branch
5 times, most recently
from
22ede81 to
9857cfd
Compare
charmander
force-pushed
the
ci-postgresql-10
branch
from
eafd070 to
e305321
Compare
and change to Ubuntu 18.04 so building OpenSSL isn’t necessary, and move old PostgreSQL version tests to the latest Node LTS.
charmander
force-pushed
the
ci-postgresql-10
branch
from
e305321 to
9284f24
Compare
|
@brianc Not quite, but I’ve fixed it. :) |
|
amazing!! Thank you. Do you have experience w/ postgres & self-signed certs? I'd love to write some tests against our whole client certificate checking snafu from earlier. |
|
@brianc Yep, I can try that in a few days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and change to Ubuntu 18.04 so building OpenSSL isn’t necessary, and move old PostgreSQL version tests to the latest Node LTS.
Depends on #1946.