Destroy socket when there was an error on it #1975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll try to take a look at this tomorrow/wed - sorry for the delay. It looks reasonable but I need to be at a computer to run some tests with it. |
charmander
reviewed
Nov 11, 2019
|
one of the tests is still failing here - do you need my help getting it to pass? You may just need to rebase w/ master. |
|
Hey, after the fix of tests in #1946 it waits for brianc/node-pg-pool#131. With this fix it works fine. I also added version for pg-native even though it doesn't have this problem, just to stay consistent. |
When error happens on socket, potentially dead socket is kept open indefinitely by calling "connection.end()". Similar issue is that it keeps socket open until long-running query is finished even though the connection was ended.
|
@brianc as brianc/node-pg-pool#131 was merged I rebased it and it looks ok. |
|
ping @brianc |
|
Hey nice! This looks good! Sorry for missing your earlier comment, I was having some email configuration issues up until recently. Fixed now though. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When error happens on socket, potentially dead socket is kept open indefinitely by calling "connection.end()".
Similar issue is that it keeps socket open until long-running query is finished even though the connection was ended.
It has to wait for #1946 to fix tests