Clear connection timeout on error #2015
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the connection gets unexpectedly dropped during the connection phase (in my case because the database is too busy) then the error handler doesn't cancel the connection timeout. This results in an 'unexpected disconnection' error, followed some seconds later by a 'connection timeout' error.
This prevents any user code from terminating while the second timeout handler is counting down, which in some environments (like AWS Lamba) where you pay by the second, will cost more money while the script sits there waiting for the now superfluous connection timeout to expire.
This PR cancels the connection timeout in the error handler, allowing scripts that wish to exit immediately to do so.