Add pg-pool to monorepo #2048
Merged
Add pg-pool to monorepo #2048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demonstrate that pg-pool exports Pool constructor
Prevent `generic-pool` error when releasing a client with an error. Fixes #2
Accept a `log: (message, other...) => { }` parameter as a config option, but by default use a no-op function instead of debug.
* Have pool emit 'connect' callback with client * Ensure pool emits client on connect event
* Add travis.yml file * Remove test on [email protected] since travis does not support it
Add travis badge
Add a section with instructions on where to instantiate your pool
* Add callback interface to pool#query * Fix linting errors
* Add connection & query timeout if all clients are checked out This addresses [pg#1390](#1390). Ensure connection timeout applies both for new connections and on an exhuasted pool. I also made the library return an error when passing a function as the first param to `pool.query` - previosuly this threw a sync type error. * Add pg-cursor to dev deps
* Add failing test for idle timer continuation after removal * Clear idle timeout only for removed client * Copy list of idle clients for modification during iteration
* Update CI versions PostgreSQL 9.1 is no longer available on 14.04. * Add Node 9 to CI
* Count only test query itself This breaks more obviously in PostgreSQL 10 (https://wiki.postgresql.org/wiki/New_in_postgres_10#Significant_Expansion_of_Wait_Events_in_pg_stat_activity). * Fix query counting for PostgreSQL 9.1
* Add failing test for correct removal from checkout queue on timeout * Remove timed-out checkouts from queue correctly Fixes #85.
Existing log code was outputting 'connecting new client' twice and saying 'new client connected', creating a false impression when an error (like a timeout) was present.
* Test queued checkout after a connection failure Co-authored-by: Johannes Würbach <[email protected]> * Fix queued checkout after a connection failure Co-authored-by: Johannes Würbach <[email protected]>
* Upgrade to test on node 10 * Use errno instead of code * Only check errno if it exists
* Prevent double release with callback When using the callback instead of client.release, double releasing a client was possible causing clients to be re-added multiple times. * Remove idleListener when client is in-use When a client is in-use, the error handling should be done by the consumer and not by the pool itself as this otherwise might cause errors to be handled multiple times. * Handle verify failures
Because it no longer exists.
The throwOnRelease() function does not appear to be exposed anywhere, and it does not appear to make any sense to have it as a standalone func, as it ovecomplicates things and makes function call as non-returning. Inlined it.
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.11 to 4.17.13. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.11...4.17.13) Signed-off-by: dependabot[bot] <[email protected]>
If an error not related to the query occurs, the client is emitting an error event. Forward this event to the callback.
Bumps [js-yaml](https://github.com/nodeca/js-yaml) from 3.12.0 to 3.13.1. - [Release notes](https://github.com/nodeca/js-yaml/releases) - [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md) - [Commits](nodeca/js-yaml@3.12.0...3.13.1) Signed-off-by: dependabot[bot] <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using the
git subtreeapproach to preserve commits. Also deleted some unused files like nested.gitignoreandyarn.lockfiles in sub-packages which aren't used anymore.