Add informative SASL empty password error message #2899
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charmander
reviewed
Jan 20, 2023
sehrope
force-pushed
the
fix-sasl-empty-password-error-message
branch
from
7898723 to
49432be
Compare
|
Looks good, but I don’t understand how it can help with #2757. Anyone who’s hitting that error message won’t hit this one, right? |
|
@charmander As usual, you're right :D Studying this a bit more I realized the SASL integration tests weren't even being run in CI. I've created a new PR, #2901, that fixes that and all this too. Closing this out in favor of that newer PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit adds a test for non-string password values being used for SASL authentication. The main code already throws an error for it but it wasn't tested anywhere.
Second commit adds a new error message when SASL authentication is requested by the server but the password is a zero-length string. This would already be a failure situation as you cannot have a zero-length password with SASL auth. This commit just changes it so the user gets an error of:
SASL: SCRAM-SERVER-FIRST-MESSAGE: client password must be a non-empty string. Also adds a unit test for it.I didn't merge the two checks and error messages as they're more informative for the end user separately.
Addresses and somewhat closes #2757.