Skip to content

fix(pg-pool): don't throw on readonly .message e.g. ErrorEvent, preserve original exception #3374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 10, 2025
+1 −1
Merged

fix(pg-pool): don't throw on readonly .message e.g. ErrorEvent, preserve original exception #3374

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33e8249
fix(pg-pool): preserve original error on connection timeout, don't th…
andyjy Feb 10, 2025
b6e8526
Fix lint
andyjy Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/pg-pool/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@
// remove the dead client from our list of clients
this._clients = this._clients.filter((c) => c !== client)
if (timeoutHit) {
err.message = 'Connection terminated due to connection timeout'
err = new Error('Connection terminated due to connection timeout', { cause: err } )

Check failure on line 247 in packages/pg-pool/index.js

View workflow job for this annotation

GitHub Actions / lint 

Delete `·`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node.js support for Error.cause added in 16.9.0, prior versions will silently ignore - has the effect of losing the stack trace of the original exception under these older Node.js versions

}

// this client won’t be released, so move on immediately
Expand Down
Loading