buffer.write Unknown Encoding bug fix #65
Conversation
|
this is blowing up my live site, reverting, plz fix |
|
Same problem here using v0.4.9 and pg version from npm. |
|
The problem is the api mismatch between Node 0.4.x and 0.5.+. 0.5.+ has a length argument to buffer.write, current stable node does not. The released npm package should have been for node > 0.5.x then you should not be able to install on stable node. The fix is not to remove the length. That should remain going forward imho. |
|
sorry about that...I had the wrong branch checked out on my node4 test machine. I'll work on this right now. |
|
hmm...unit tests faill with this pull request...I'll fix the bug, but I don't think this is merge material. I get: Error: unknown encoding |
|
I appreciate the pull request. I'd like to elaborate on what happend... In this circumstance instead of taking the pull request and fixing compatibility with node v0.4.x and breaking it again for v0.5.x I did a little bit of hackery to make pg run on both "branches" of node. Sorry for the oversight on this not working earlier. I always test things on node v0.4.x and node v0.5.x, but I screwed up the remote references on the test box and thought things were green when they were actually red. My glasses broke this week, and I've had to wear an old pair which is causing a headache + difficulty reading screen...so let's chalk it up to that and move on, yes yes? |
|
Your quick turnaround time forgives all :) No excuses required! |
* Bump version of pg-cursor This includes fixes in [email protected]. I've relaxed semver a touch so I don't have to release a new version here just for patch changes to pg-cursor. * Pass options to pg-cursor fixes #55
When the pool emits an error pass the client as the 2nd parameter to the `on('error')` handler.
the commit 46f6d90 breaks the buffer api
unit tests were not passing anymore