[WIP] PEPPER-733-kit-upload-test-for-rgp #2088
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test to handle testing that a blood and rna kit can be uploaded and scanned
Rinchan20
commented
Apr 13, 2023
| //Inputting the various kit types that can be uploaded in DSM | ||
| //todo Update as needed as more kit upload tests are created | ||
| enum KitType { | ||
| BLOOD = 'BLOOD', |
There was a problem hiding this comment.
all kits (for rgp) are planned to be blood & rna instead of blood (if they aren't already - will check with Jeff)
Rinchan20
commented
Apr 13, 2023
| } | ||
|
|
||
| public getSkipAddressValidationOption(): Locator { | ||
| return this.page.locator('text=Skip address validation on upload'); |
There was a problem hiding this comment.
need to re-check if spaces are allowed here in typescript - just checked to make sure that the label can be acquired via xpath (but I prefer playwright selector read-ability - so...)
some updates - used help from codegen
running the tests gets to kit upload page now - changed 'verify' to 'assert'
test could not find element with the location given from codegen - test currently goes up to Kit Upload page and then select "Blood & RNA" kit option. Also moved kit type enums to its own file since a lot of samples menu pages will use those.
forgot to use the passed in kit type within the function while checking the test
zyme
reviewed
Apr 14, 2023
|
|
||
| test('Can upload a Blood & RNA kit @functional @rgp', async ({ page }) => { | ||
| //Go to DSM in order to do a kit upload (type: "BLOOD & RNA") | ||
| await welcomePage.selectStudy(Study.RGP); |
There was a problem hiding this comment.
I think we want the assertions to live inside the tests, but use the page classes to return values. So maybe have the home page return the study title or the welcome title, and then make the assertion in this file.
|
handled by #2183 - closing this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test to handle testing that a blood and rna kit can be uploaded and scanned