-
Notifications
You must be signed in to change notification settings - Fork 4
[Playwright] DSM Tissue-Request test is not working on CircleCI #2240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
await expect(modal.bodyLocator()).toHaveText(/Are you sure you want to change the destruction policy for all of the tissues from this facility/); | ||
const yesBtn = modal.getButton({ label: 'Yes' }).toLocator(); | ||
await yesBtn.click(); | ||
// after click Yes button, dialog window is automatically handled by Playwright |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Playwright automatically closed the alert window. doc
.circleci/config.yml
Outdated
name: Run all DSM tests on << parameters.env >> CIRCLE_NODE_INDEX = 0 | ||
working_directory: *playwright_path | ||
command: | | ||
npx playwright test --list | grep -o 'tests/.*.spec.ts' | sort | uniq > e2e_tests.txt | ||
TESTS_FILE=$(circleci tests split --split-by=timings --timings-type=classname e2e_tests.txt) | ||
echo $TESTS_FILE | ||
npm run test:ci $TESTS_FILE | ||
no_output_timeout: 5m # Default is 10m. Set shorter time to ensure CI fails faster if test hangs | ||
command: | | ||
if [ ${CIRCLE_NODE_INDEX} == "0" ]; | ||
then | ||
npx playwright test --project="dsm" | ||
fi | ||
no_output_timeout: 5m | ||
- run: | ||
name: Run all DSS tests on << parameters.env >> CIRCLE_NODE_INDEX = 1 | ||
working_directory: *playwright_path | ||
command: | | ||
if [ ${CIRCLE_NODE_INDEX} == "1" ]; | ||
then | ||
npx playwright test --project="dss" | ||
fi | ||
no_output_timeout: 5m |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Split tests across two different CircleCI VM: DSS and DSM tests run separately.
This way, only 2 DSM tests could run concurrently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks for fixing that
Playwright test
dsm/tissue-request/cmi-tissue-request.spec.ts
fails on CircleCI.