Skip to content

Playwright_Fix DSM Osteo screenshot comparison failure #2382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Playwright_Fix DSM Osteo screenshot comparison failure #2382

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion playwright-e2e/playwright.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ const testConfig: PlaywrightTestConfig = {
scale: 'css',
// Account for minor difference in text rendering and resolution between headless and headed mode
threshold: 1,
maxDiffPixelRatio: 0.5
maxDiffPixelRatio: 1
Copy link
Contributor Author

@Rinchan20 Rinchan20 May 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change is specifically for the toHaveScreenshot() method since that's what's failing - bumped it up from 0.5 to 1 to see if it helps - it seems that it's problem a lot of people run into based on what I can see from threads like: microsoft/playwright#18827

seems allowed based on:
Screenshot 2024-05-16 at 12 51 10 PM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok that didn't seem to fix it just yet (ran feature branch on circleci)

}
},
/* Run tests in files in parallel */
Expand Down