DDP-6918: Fix Autocomplete list scrolling [Pancan] #878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it should be under the main header by scrolling
|
Discussed with Marco that it is a corner case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous fix PR#869 causes to another non caught bug.
We put autocomplete scroll under app header by scrolling. However other components (e.g. language selector) uses the same overlay container and also appear under the header.
See screenshots: (currently on dev, after the previous fix)
It is quite tough (if possible?) to tweak it by css. And it is a known Angular materials issue.
So it should be done in another way.
The simplest one is just closing any autocomplete suggestions list like it was done firstly (0171b33).
On the other hand it's not a user friendly behavior.
Thus I have fixed it a bit tricky, but it is working.
See screenshots after the fix:
