Skip to content

move imports in generated android/build.gradle #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 15, 2019

Conversation

brody4hire
Copy link
Owner

move the following lines near the beginning:

apply plugin: 'com.android.library'
apply plugin: 'maven'

as a followup to PR #135

verified the following with PR #140 (move some constants) applied to my workarea:

  • ✅ able to generate view module with example that works with React Native 0.59
  • ✅ able to generate non-view module with example that works with React Native 0.59
  • ✅ able to generate non-view module with example that works with React Native 0.60
  • ✅ able to generate non-view module with example that works with React Native 0.61-rc

/cc @friederbluemle

move the following lines near the beginning:

    apply plugin: 'com.android.library'
    apply plugin: 'maven'
@brody4hire brody4hire merged commit 737b199 into dev Nov 15, 2019
@brody4hire brody4hire deleted the move-gradle-plugin-imports branch November 15, 2019 05:02
brody4hire pushed a commit that referenced this pull request Nov 15, 2019
move the following lines near the beginning:

    apply plugin: 'com.android.library'
    apply plugin: 'maven'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant