fix API & option descriptions #301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brody4hire
commented
Apr 2, 2020
brody4hire
commented
Apr 2, 2020
| @@ -128,10 +128,10 @@ createLibraryModule({ | |||
|
|
|||
| ```javascript | |||
| { | |||
| name: String, /* The name of the library (Default: Library) */ | |||
| prefix: String, /* The prefix for the library (Default: ``) */ | |||
| name: String, /* The name of the library (mandatory) */ | |||
There was a problem hiding this comment.
Suggested change
| name: String, /* The name of the library (mandatory) */ | |
| name: String, /* The name of the library (Mandatory) */ |
brody4hire
commented
Apr 2, 2020
| @@ -128,10 +128,10 @@ createLibraryModule({ | |||
|
|
|||
| ```javascript | |||
| { | |||
| name: String, /* The name of the library (Default: Library) */ | |||
| prefix: String, /* The prefix for the library (Default: ``) */ | |||
| name: String, /* The name of the library (mandatory) */ | |||
There was a problem hiding this comment.
or maybe this:
Suggested change
| name: String, /* The name of the library (mandatory) */ | |
| name: String, /* The name of the library - mandatory */ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nameparameter in the library API--prefix&--module-prefixdescriptions inREADME.md--prefix&--module-prefixdescriptions incli-command.jsfollowup to reverted PR #278 (reverted in #299) which was in followup to PRs #276 & #264 (removing Windows C# platform support)
I think this series of updates and fixes shows the benefit of slower and more careful development.