Skip to content

DeprecationWarning on node 7 #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dominicbarnes opened this issue Oct 26, 2016 · 6 comments
Closed

DeprecationWarning on node 7 #76

dominicbarnes opened this issue Oct 26, 2016 · 6 comments

Comments

@dominicbarnes
Copy link
Contributor

I'm using browser-pack in a project of my own, and I discovered a warning when running my tests on node 7. (recently released)

(node:28861) DeprecationWarning: Using Buffer without new will soon stop working. Use new Buffer(), or preferably Buffer.from(), Buffer.allocUnsafe() or Buffer.alloc() instead.

There are several places in this library that use the Buffer() syntax instead of new Buffer(), and it should be an easy update, as well as being backwards-compatible.

@dominicbarnes
Copy link
Contributor Author

Looks like there is already a PR (#75) to address this, can we get it merged?

@TehShrike
Copy link

I'm getting this deprecation warning as well.

@ai
Copy link

ai commented Nov 21, 2016

Seems like issue was fixed c91b816

But this fix was not released.

@zertosh @thealphanerd @substack how I can help with release of this fix?

@ai
Copy link

ai commented Nov 21, 2016

Every Browserify user with node.js 7 have this warning browserify/browserify#1616 (comment)

@davidmarkclements
Copy link

Afaik the deprecation is being (or has been) reversed (davidmarkclements/0x#52)

@ghost
Copy link

ghost commented Feb 18, 2017

wontfix

@ghost ghost closed this as completed Feb 18, 2017
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants