use new to instantiate all buffers
#75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using Buffer without `new` will soon stop working. It will throw A deprecation warning in Node v7.
MylesBorins
pushed a commit
to MylesBorins/node-browserify
that referenced
this pull request
Aug 31, 2016
Using Buffer without new will soon stop working. It will throw A deprecation warning in Node v7. This commit modifies the tests in `test/bare.js` and `test/bare_shebang.js` to use the `Buffer.from` interface instead. It is a drop in replacement for Buffer that is supported by Node v4 / v6 and Browserify's Buffer implementation For the browserify test suite to pass on Node v7 we will need to land this commit as well as the two below PR's * browserify/browser-pack#75 * max-mapper/concat-stream#48
This was referenced Aug 31, 2016
|
lgtm |
|
btw, this pull request fixes #76. |
|
Bump |
|
I can't see any problem with this. |
|
Can we please get a bugfix release for this? That would be nice. |
|
This doesn't fix anything. There is no clear roadmap for core. Adding |
|
It fixes issue #76, "annoying warning showing up in logs". |
|
Also don't see what the problem is with releasing a patch version in this case. Yes no logic changed, but having no deprecation warnings is a good thing. /cc @zertosh |
|
This shouldn't have been merged but I don't blame anyone except for node core. |
|
@substack we reverted in core. LMK if you would like me to submit a revert PR to browser-pack |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Buffer without
newwill soon stop working. It will throwA deprecation warning in Node v7.