Skip to content

Fix example #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix example #78

wants to merge 5 commits into from

Conversation

Chaitya62
Copy link
Member

Example in async style.

Chaitya Shah and others added 2 commits May 31, 2019 13:30
@Chaitya62
Copy link
Member Author

Chaitya62 commented May 31, 2019 •
edited
Loading

@singh811 Is there some issue with the master, I have changed the readme still the CI failed ?

Also regarding my example: is the
yourTest function misleading, how else can we show that stop should be called when test is completed ?

  • Writing a Dummy for yourTest which returns a promise could be and option.

nimit95
nimit95 reviewed Jun 18, 2019
View reviewed changes
yashLadha
yashLadha reviewed Jan 23, 2020
View reviewed changes
README.md
if (bs_local.isRunning()) {

// run your test here
yourTest(function() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe using a much more contextual name like testScenario or something on these lines?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nimit95 nimit95 nimit95 left review comments

@yashLadha yashLadha yashLadha left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Chaitya62 @nimit95 @yashLadha