Fix crash from property 'browser_version' undefined #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When no match is found, the process would just crash. Instead, recognise
this as a normal end-user scenario and point them to the list of
available workers.
In my experience the most common way to encounter this issue is when
additional decimal places are required by the API, e.g. "safari"
"9" results in a crash, because the available workers are described
as "9.1" instead. Given that most browers are described without a
decimal place, this is an easy mistake to make.
Another way to get this is when there is a misspelled browser name.
Before:
```
TypeError: Cannot read property 'browser_version' of undefined
at browserstack-runner/bin/cli.js
```
After:
```
Error: No desktop match found for {"browser":"safari","browser_version":"9"}
Check https://www.browserstack.com/list-of-browsers-and-platforms/js_testing
at populateOsAndOsVersion (browserstack-runner/lib/configParser.js)
```
Fixes browserstack#243.
yashLadha
approved these changes
Apr 19, 2021
francisf
approved these changes
Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When no match is found, the process would just crash. Instead, recognise this as a normal end-user scenario and point them to the list of available workers.
In my experience the most common way to encounter this issue is when additional decimal places are required by the API, e.g.
safari_9results in a crash, because the available workers are described as "9.1" instead. Given that most browers are described without a decimal place, this is an easy mistake to make.Another way to get this is when there is a misspelled browser name.
Before:
After:
Fixes #243.