refactor(dockerfile): builder multistage pattern & random uid user support #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Please note: this build depends on the work being done in verdaccio under verdaccio/verdaccio#864, in order to build this, it's needed to create a manual build of that verdaccio's PR and manually tag it: # In verdaccio PR #864
cd ..
yarn build:docker
docker tag verdaccio:latest verdaccio/verdaccio:3.3
# Now build this image
cd ...
yarn build:docker
# available as verdaccio-gitlab:latest |
dlouzan
force-pushed
the
refactor/docker-multistage-build
branch
2 times, most recently
from
19a02fc to
efea6da
Compare
|
I'm changing this to make it depend on verdaccio/verdaccio:4.x-next. But until the changes in the pending PR in verdaccio for refactored dockerfile are applied, this won't work unless we build manually locally (see comment above) |
|
It's out |
|
This is great! Please seperate the fixes for gitlab.js and package.json into a dedicated PR as they are not related to the docker build. |
- build image based on current upstream verdaccio refactor, only building the plugin code and then symlinking the plugin code - randomized uid support (e.g. openshift) - plugin install directory is read-only
dlouzan
force-pushed
the
refactor/docker-multistage-build
branch
from
efea6da to
6edd701
Compare
This was referenced Jul 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
building the plugin code and then symlinking the plugin code