This repository was archived by the owner on Mar 1, 2019. It is now read-only.
Work around webpack-dev-server hostname checking requirement #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Insta-merging given I'm the only consumer of these docker containers. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix security things, webpack-dev-server added a check for hostname in webpack/webpack-dev-server#887.
Unfortunately, they also used that host check as the address to bind to, with only 127.0.0.1 and localhost as exceptions. This breaks docker containers or proxies.
The workaround is to set up a host entry in the container for
buildkite.devto point to0.0.0.0. This then still has the hostname check, but it binds to the correct interface in the container.