Skip to content

chore: test sql review #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 5, 2025
Merged

chore: test sql review #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e8507a
chore: test sql review
RainbowDashy Jun 3, 2025
9264ce6
update yaml
RainbowDashy Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/sql-review-action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ jobs:
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # set GITHUB_TOKEN because the 'Check release' step needs it to comment the pull request with check results.
BYTEBASE_URL: https://demo.bytebase.com
BYTEBASE_SERVICE_ACCOUNT: ci@service.bytebase.com
BYTEBASE_SERVICE_ACCOUNT_SECRET: "bbs_iqysPHMqhNpG4rQ5SFEJ"
BYTEBASE_PROJECT: "projects/project-sample"
BYTEBASE_SERVICE_ACCOUNT: api@service.bytebase.com
BYTEBASE_SERVICE_ACCOUNT_SECRET: "bbs_EDyd8zleJVBEZyw81kLL"
BYTEBASE_PROJECT: "projects/hr"
BYTEBASE_TARGETS: "instances/prod-sample-instance/databases/hr_prod"
FILE_PATTERN: "migrations-semver/*.sql"
run: |
Expand Down
4 changes: 3 additions & 1 deletion migrations-semver/1.13.0_phone.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,3 @@
ALTER TABLE IF EXISTS users ADD COLUMN IF NOT EXISTS phone VARCHAR(255) NOT NULL DEFAULT '';
ALTER TABLE IF EXISTS users ADD COLUMN IF NOT EXISTS phone VARCHAR(255) NOT NULL DEFAULT '';

Check failure on line 1 in migrations-semver/1.13.0_phone.sql

View workflow job for this annotation

GitHub Actions / check-release-on-prod

column.comment (Ј) 

Comment is required for column `users.phone`. Targets: instances/prod-sample-instance/databases/hr_prod  https://www.bytebase.com/docs/reference/error-code/advisor#Ј

INSERT INTO users VALUES (1);

Check failure on line 3 in migrations-semver/1.13.0_phone.sql

View workflow job for this annotation

GitHub Actions / check-release-on-prod

statement.dml-dry-run (Ð) 

"INSERT INTO users VALUES (1);" dry runs failed: ERROR: relation "users" does not exist (SQLSTATE 42P01). Targets: instances/prod-sample-instance/databases/hr_prod  https://www.bytebase.com/docs/reference/error-code/advisor#Ð

Check failure on line 3 in migrations-semver/1.13.0_phone.sql

View workflow job for this annotation

GitHub Actions / check-release-on-prod

statement.insert.must-specify-column (ѓ) 

The INSERT statement must specify columns but "INSERT INTO users VALUES (1);" does not. Targets: instances/prod-sample-instance/databases/hr_prod  https://www.bytebase.com/docs/reference/error-code/advisor#ѓ
Loading