Skip to content

chore: fix some comments #1416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

yudrywet
Copy link

remove redundant word in comment

@sunfishcode
Copy link
Member

Those words aren't redundant; "linked in" is a phrasal verb meaning that a library is included is the final output, and "in lto builds" is a prepositional phrase describing a build configuration. That said, I'm open to ideas for how to improve the wording to clarify this comment.

@yudrywet
Copy link
Author

yudrywet commented Mar 13, 2025

Those words aren't redundant; "linked in" is a phrasal verb meaning that a library is included is the final output, and "in lto builds" is a prepositional phrase describing a build configuration. That said, I'm open to ideas for how to improve the wording to clarify this comment.

Thank you for the clarification on the phrasal verb usage. The revised comment now preserves "linked in" as a verb phrase while making these improvements:

  1. Technical precision: Differentiates between .weak (handling symbol visibility) and .ifndef (preprocessor collision avoidance)

  2. Build context clarity: Uses parallel structure for "non-LTO builds" vs "LTO builds"

@yudrywet yudrywet changed the title chore: remove redundant word in comment chore: fix some comments Mar 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants