WIP: Update SIMD instructions #105
Conversation
|
Thanks for this! Would you be ok linking some of the PRs on the simd repo here for posterity too where the renames happened? Additionally I think this is fine to land and not block on webassembly/testsuite and/or webassembly/wabt being updated, there's various locations throughout roundtrip.rs where test are ignored and you can add some TODO/FIXME items to get removed in the future. |
|
Here are links to the respective PRs where the recent renaming and additions to the SIMD proposal were made: WebAssembly/simd#321 I've also created PRs for WebAssembly/testsuite and WebAssembly/wabt: |
silvanshade
force-pushed
the
update-simd
branch
from
fd6380b to
a9f5879
Compare
|
I've updated the PR, temporarily pointing my local branches of Note that I had to modify |
|
Looks great to me, thanks again for all your help here on this! To bikeshed a bit, though, the name "signededness" is a bit overloaded with integers themselves and the token in front, and I was a bit perplexed at Perhaps a name like |
silvanshade
force-pushed
the
update-simd
branch
3 times, most recently
from
8830ce4 to
0abaca0
Compare
|
I've got a commit at alexcrichton@954df9d which updates to the upstream testsuite module now with some other assorted fixes that cropped up, feel free to cherry-pick that here or take what you like from it! With the submodules set back to upstream repos I think this should be good to merge. |
silvanshade
force-pushed
the
update-simd
branch
3 times, most recently
from
7cdd02d to
8b39a4d
Compare
* Update the upstream testsuite to the current master branch * Update wabt to the current master branch * Get the test suite working with SIMD/memory64 changes (mostly just ignoring memory64 and simd with wabt)
silvanshade
force-pushed
the
update-simd
branch
from
8b39a4d to
f32475a
Compare
|
@alexcrichton I think this should be good to go now. |
|
Perfect, thanks again! |
This is an automated pull request from CI to release wasmfx-tools 1.211.2 when merged. The commit message for this PR has a marker that is detected by CI to create tags and publish crate artifacts. When first opened this PR will not have CI run because it is generated by a bot. A maintainer should close this PR and then reopen it to trigger CI to execute which will then enable merging this PR. Co-authored-by: Auto Release Process <[email protected]>
This reverts commit 575638c.
…ealliance#106) This reverts commit 575638c.
This PR updates SIMD support to reflect recent syntax changes (and new instructions) in the proposal repo.
This PR allows
wastto successfully parse all of the test files in the upstream WebAssembly/simd repo (tested with the testsuite for the webassembly language server, which useswast) but unfortunately it breaks a lot of the tests intests/local,tests/testsuite, andtests/wabtwhich still use the old syntax.I tried fixing some of the tests in
tests/localbut wasn't sure about some of the errors. I also tried regenerating the upstream WebAssembly/testsuite but theupdate-testsuite.shscript fails on several of the repos with unresolvable merge conflicts and I wasn't sure how to work around that without messing up the script workflow.So for the meantime I will just leave this here.