Skip to content

Add SIMD int-to-float conversion #1263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 17, 2020

Conversation

abrown
Copy link
Contributor

@abrown abrown commented Mar 9, 2020

This adds support for f32x4.convert_i32x4_s for x86. This conversion is a simple 1:1 lowering; other conversions will not be (see WebAssembly/simd#190).

@abrown abrown requested a review from bnjbvr March 9, 2020 16:43
@github-actions github-actions bot added cranelift Issues related to the Cranelift code generator cranelift:meta Everything related to the meta-language. labels Mar 11, 2020
@github-actions
Copy link

Subscribe to Label Action

This issue or pull request has been labeled: "c", "r", "a", "n", "e", "l", "i", "f", "t"

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

1 similar comment
@github-actions
Copy link

Subscribe to Label Action

This issue or pull request has been labeled: "c", "r", "a", "n", "e", "l", "i", "f", "t"

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

@abrown abrown force-pushed the int-to-float-32 branch 2 times, most recently from 304d72f to 4872334 Compare March 14, 2020 00:22
@github-actions
Copy link

Subscribe to Label Action

This issue or pull request has been labeled: "cranelift", "cranelift:meta", "cranelift:wasm"

Users Subscribed to "cranelift"

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

Copy link
Member

@bnjbvr bnjbvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@abrown abrown merged commit ffa467a into bytecodealliance:master Mar 17, 2020
@abrown abrown deleted the int-to-float-32 branch March 17, 2020 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cranelift:meta Everything related to the meta-language. cranelift:wasm cranelift Issues related to the Cranelift code generator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants