Skip to content

Remove obsolete test exclusions. #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions crates/gen-guest-c/tests/codegen.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,26 +2,27 @@ use std::env;
use std::path::{Path, PathBuf};
use std::process::Command;

#[rustfmt::skip]
mod imports {
test_helpers::codegen_c_import!(
"*.wit"

// TODO: implement async support
"!async-functions.wit"
// If you want to exclude a specific test you can include it here with
// gitignore glob syntax:
//
// "!wasm.wit"
// "!host.wit"
//
//
// Similarly you can also just remove the `*.wit` glob and list tests
// individually if you're debugging.
);
}

#[rustfmt::skip]
mod exports {
test_helpers::codegen_c_export!(
"*.wit"

// TODO: implement async support
"!async-functions.wit"

// TODO: these use push/pull buffer in exports which isn't implemented
// yet
"!wasi-next.wit"
"!host.wit"
);
}

Expand Down
6 changes: 1 addition & 5 deletions crates/gen-guest-rust/tests/codegen.rs
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,9 @@ mod imports {
);
}

#[rustfmt::skip]
mod exports {
test_helpers::codegen_rust_wasm_export!(
"*.wit"

// TODO: these use push/pull buffer which isn't implemented in the test
// generator just yet
"!wasi-next.wit"
"!host.wit"
);
}
18 changes: 11 additions & 7 deletions crates/gen-guest-teavm-java/tests/codegen.rs
Original file line number Diff line number Diff line change
@@ -1,23 +1,27 @@
use heck::{ToSnakeCase, ToUpperCamelCase};
use std::{fs, path::Path, process::Command};

#[rustfmt::skip]
mod imports {
test_helpers::codegen_teavm_java_import!(
"*.wit"

// TODO: implement async and resource support
"!async-functions.wit"
"!resource.wit"
// If you want to exclude a specific test you can include it here with
// gitignore glob syntax:
//
// "!wasm.wit"
// "!host.wit"
//
//
// Similarly you can also just remove the `*.wit` glob and list tests
// individually if you're debugging.
);
}

#[rustfmt::skip]
mod exports {
test_helpers::codegen_teavm_java_export!(
"*.wit"

// TODO: implement async and resource support
"!async-functions.wit"
"!resource.wit"
);
}

Expand Down
18 changes: 12 additions & 6 deletions crates/gen-host-js/tests/codegen.rs
Original file line number Diff line number Diff line change
@@ -1,21 +1,27 @@
use std::path::Path;
use std::process::Command;

#[rustfmt::skip]
mod exports {
test_helpers::codegen_js_export!(
// ...
"*.wit"

// If you want to exclude a specific test you can include it here with
// gitignore glob syntax:
//
// "!wasm.wit"
// "!host.wit"
//
//
// Similarly you can also just remove the `*.wit` glob and list tests
// individually if you're debugging.
);
}

#[rustfmt::skip]
mod imports {
test_helpers::codegen_js_import!(
"*.wit"

// This uses buffers, which we don't support in imports just yet
// TODO: should support this
"!wasi-next.wit"
"!host.wit"
);
}

Expand Down
21 changes: 11 additions & 10 deletions crates/gen-host-wasmtime-py/tests/codegen.rs
Original file line number Diff line number Diff line change
@@ -1,26 +1,27 @@
use std::path::Path;
use std::process::Command;

#[rustfmt::skip]
mod exports {
test_helpers::codegen_py_export!(
"*.wit"

// TODO: implement async support
"!async-functions.wit"
// If you want to exclude a specific test you can include it here with
// gitignore glob syntax:
//
// "!wasm.wit"
// "!host.wit"
//
//
// Similarly you can also just remove the `*.wit` glob and list tests
// individually if you're debugging.
);
}

#[rustfmt::skip]
mod imports {
test_helpers::codegen_py_import!(
"*.wit"

// TODO: implement async support
"!async-functions.wit"

// This uses buffers, which we don't support in imports just yet
// TODO: should support this
"!wasi-next.wit"
"!host.wit"
);
}

Expand Down
12 changes: 1 addition & 11 deletions crates/gen-host-wasmtime-rust/tests/codegen.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,6 @@ mod exports {
test_helpers::codegen_wasmtime_export!(
"*.wit"

// TODO: implement async support
"!async-functions.wit"

// If you want to exclude a specific test you can include it here with
// gitignore glob syntax:
//
Expand All @@ -24,17 +21,10 @@ mod exports {
);
}

#[rustfmt::skip]
mod imports {
test_helpers::codegen_wasmtime_import!(
"*.wit"

// TODO: implement async support
"!async-functions.wit"

// TODO: these use push/pull buffer which isn't implemented in the test
// generator just yet
"!wasi-next.wit"
"!host.wit"
);
}

Expand Down