wasmtime: Remove lifetime and type parameter from exports #374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the type parameter since it's unused at this time. It was historically used for handles but that's under development again so it's no longer needed. This commit then additionally removes the lifetime parameter from the structure, opting to store `Func` instead of `TypedFunc` to avoid the need to name types and their lifetime parameters. Functions internally then use `TypedFunc::new_unchecked` to re-acquire the typed view with appropriate anonymous lifetimes in parameters.
pchickey
approved these changes
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the type parameter since it's unused at this time. It was historically used for handles but that's under development again so it's no longer needed. This commit then additionally removes the lifetime parameter from the structure, opting to store
Funcinstead ofTypedFuncto avoid the need to name types and their lifetime parameters. Functions internally then useTypedFunc::new_uncheckedto re-acquire the typed view with appropriate anonymous lifetimes in parameters.