Skip to content

Docs issues with bytesize 2.0 #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
marxin opened this issue Feb 27, 2025 · 0 comments · Fixed by #83
Closed

Docs issues with bytesize 2.0 #82

marxin opened this issue Feb 27, 2025 · 0 comments · Fixed by #83

Comments

@marxin
Copy link
Contributor

marxin commented Feb 27, 2025

First of all, thanks for a neat crate. I've just noticed there is wrong docs for the newly added Display-related functions:

    /// Format using SI (decimal) units.    
    pub fn iec_short(mut self) -> Self {

I think this should be: Format using a short style and IEC (binary) units.

    /// Format using a short style and IEC (binary) units.
    pub fn si(mut self) -> Self {

Should be: Format using SI (decimal) units.

marxin added a commit to marxin/bytesize that referenced this issue Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant