Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: functiontool supports asynchronous functions #2078

Conversation

koch3092
Copy link
Collaborator

@koch3092 koch3092 commented Apr 1, 2025

Description

Fixed a bug: When adding the timeout feature to the FunctionTool object method, keep the synchronous and asynchronous method feature to support asynchronous methods as FunctionTool calls.

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have read the CONTRIBUTION guide (required)
  • I have linked this PR to an issue using the Development section on the right sidebar or by adding Fixes #issue-number in the PR description (required)
  • I have checked if any dependencies need to be added or updated in pyproject.toml and uv lock
  • I have updated the tests accordingly (required for a bug fix or a new feature)
  • I have updated the documentation if needed:
  • I have added examples if this is a new feature

If you are unsure about any of these, don't hesitate to ask. We are here to help!

@koch3092 koch3092 requested a review from MuggleJinx April 1, 2025 13:49
@koch3092 koch3092 self-assigned this Apr 1, 2025
@koch3092 koch3092 linked an issue Apr 1, 2025 that may be closed by this pull request
2 tasks
Copy link
Collaborator

@MuggleJinx MuggleJinx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Wendong-Fan Wendong-Fan changed the title 2074 bug fix: functiontool supports asynchronous functions fix: functiontool supports asynchronous functions Apr 1, 2025
@Wendong-Fan Wendong-Fan merged commit e5aa310 into master Apr 1, 2025
3 of 6 checks passed
@Wendong-Fan Wendong-Fan deleted the 2074-feature-request-functiontool-supports-asynchronous-functions branch April 1, 2025 22:41
@lightaime
Copy link
Member

Can we use camel toolkit with MCP toolkit together now? It would be great to have an example on how to do it.

@Wendong-Fan
Copy link
Member

Can we use camel toolkit with MCP toolkit together now? It would be great to have an example on how to do it.

#2092

@MuggleJinx
Copy link
Collaborator

Can we use camel toolkit with MCP toolkit together now? It would be great to have an example on how to do it.

Good idea! Here u mean the example of agent using both camel tools and mcp tools together, right?

@Wendong-Fan
Copy link
Member

Can we use camel toolkit with MCP toolkit together now? It would be great to have an example on how to do it.

Good idea! Here u mean the example of agent using both camel tools and mcp tools together, right?

yeah, exactly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] FunctionTool supports asynchronous functions
4 participants