Skip to content

Need quotes for update_interval and update_interval_when_expecting config values #1176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pokidovea opened this issue Aug 19, 2024 · 1 comment · Fixed by #1177 or #1178
Closed

Need quotes for update_interval and update_interval_when_expecting config values #1176

pokidovea opened this issue Aug 19, 2024 · 1 comment · Fixed by #1177 or #1178

Comments

@pokidovea
Copy link

pokidovea commented Aug 19, 2024 •
edited
Loading

Describe the bug

update_interval and update_interval_when_expecting config values are rendered without quotes what leads to the parsing error:

    update_interval = 1m
    update_interval_when_expecting = 2s

Unexpected character, expected only whitespace or comments till end of line

Adding quotes like below solves the problem

    update_interval = "1m"
    update_interval_when_expecting = "2s"

Additional info

terraform-aws-gitlab-runner v7.13.0
@kayman-mk
Copy link
Collaborator

Arrgh, that's true.

@kayman-mk kayman-mk mentioned this issue Aug 22, 2024
Merged
@cattle-ops-releaser-2 cattle-ops-releaser-2 bot mentioned this issue Aug 22, 2024
Merged
kayman-mk pushed a commit that referenced this issue Aug 22, 2024
@cattle-ops-releaser-2 @github-actions
chore(main): release 7.13.1 (#1178)
745fc46 
🤖 I have created a release *beep* *boop*
---


##
[7.13.1](7.13.0...7.13.1)
(2024-08-22)


### Bug Fixes

* add `"` to the new `update_interval_*` options of the autoscaler
([#1177](#1177))
([e792256](e792256)),
closes
[#1176](#1176)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: cattle-ops-releaser-2[bot] <134548870+cattle-ops-releaser-2[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@pokidovea @kayman-mk