- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 338
feat: enabled usage of private key with docker autoscaler #1232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enabled usage of private key with docker autoscaler #1232
Conversation
Hey @zillemarco! 👋 Thank you for your contribution to the project. Please refer to the contribution rules for a quick overview of the process. Make sure that this PR clearly explains:
With submitting this PR you confirm that you hold the rights of the code added and agree that it will published under this LICENSE. The following ChatOps commands are supported:
Simply add a comment with the command in the first line. If you need to pass more information, separate it with a blank line from the command. This message was generated automatically. You are welcome to improve it. |
@npalm / @kayman-mk I can confirm that with these changes I am able to connect our runner manager (Unix) to the workers (Windows) (issue reported here: #1172 (comment)). I tested this on our environment, using my fork as the module's source. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for enable the module to use Windows.
Co-authored-by: Marco Zille <[email protected]>
To test the changes it's needed to set up an environment that uses a Windows AMI for the runner workers, and ensure that the manager is able to connect to the instances. |
🤖 I have created a release *beep* *boop* --- ## [9.0.0](8.1.0...9.0.0) (2025-02-09) ### ⚠ BREAKING CHANGES * remove declaration of unused variables for docker-autoscaler setup ([#1223](#1223)) * add custom egress rules to worker security groups ([#1222](#1222)) ### Features * add custom egress rules to worker security groups ([#1222](#1222)) ([a197e4f](a197e4f)) * enabled usage of private key with docker autoscaler ([#1232](#1232)) ([95c7ea6](95c7ea6)) ### Miscellaneous Chores * remove declaration of unused variables for docker-autoscaler setup ([#1223](#1223)) ([41058c8](41058c8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: cattle-ops-releaser-2[bot] <134548870+cattle-ops-releaser-2[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Matthias Kay <[email protected]>
Description
This PR enables users to explicitly allow using the private key used to authenticate the runner manager with the workers when using the
docker-autoscaler
option.This is required in order for the manager to be able to connect with the workers running Windows, as noted here: https://gitlab.com/gitlab-org/fleeting/plugins/aws#default-connector-config