Skip to content

Install the docker-ecr-credential-helper #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Fuuzetsu opened this issue Dec 9, 2020 · 2 comments
Closed

Install the docker-ecr-credential-helper #271

Fuuzetsu opened this issue Dec 9, 2020 · 2 comments
Labels
enhancement 🆕 New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Fuuzetsu
Copy link

Fuuzetsu commented Dec 9, 2020

If we want to use docker-based executors and pull docker images from private ECR, we are likely to use https://docs.gitlab.com/ee/ci/docker/using_docker_images.html#using-credential-helpers with DOCKER_AUTH_CONFIG set. To make use of this, the appropriate credential helper needs to be installed: https://github.com/awslabs/amazon-ecr-credential-helper

With current EC2 setup, this is just yum install -y amazon-ecr-credential-helper. The user can work-around this by using userdata_post_install variable but it'd be cool if there was a proper setting. It could even be on by default, there's not much reason (as far as I can tell) to not just install this by default.

@npalm
Copy link
Collaborator

npalm commented Jan 13, 2021

Thanks, great suggestion!

@npalm npalm added enhancement 🆕 New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Jan 13, 2021
anasinnyk added a commit to anasinnyk/terraform-aws-gitlab-runner that referenced this issue Feb 27, 2021
@npalm
Copy link
Collaborator

npalm commented Mar 11, 2021

solved via #311

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🆕 New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants