fix: allow changes to "runner_worker.max_jobs" for Docker Autoscaler #1221
Conversation
Remove ignore_changes from the ASG for Docker Autoscaler. The reasoning described in the comment was poor; min_size and desired_capacity are fixed at zero, so won't change, and max_size should change when runner_worker.max_jobs is changed, and will not cause immediate scale-up. If it causes scale-down, this the logical desired behaviour.
|
Hey @jonmcewen! 👋 Thank you for your contribution to the project. Please refer to the contribution rules for a quick overview of the process. Make sure that this PR clearly explains:
With submitting this PR you confirm that you hold the rights of the code added and agree that it will published under this LICENSE. The following ChatOps commands are supported:
Simply add a comment with the command in the first line. If you need to pass more information, separate it with a blank line from the command. This message was generated automatically. You are welcome to improve it. |
jonmcewen
changed the title
|
Just wondering why an ignore changes on |
That came into my mind too. |
jonmcewen
changed the title
|
@kayman-mk can this be merged now please? |
|
Looks good. Could you please update the PR description to match the change? It's used as commit message. |
🤖 I have created a release *beep* *boop* --- ## [9.0.2](9.0.1...9.0.2) (2025-02-20) ### Bug Fixes * allow changes to "runner_worker.max_jobs" for Docker Autoscaler ([#1221](#1221)) ([0624391](0624391)) * always encrypt EBS volumes if the KMS key is given ([#1248](#1248)) ([76ae944](76ae944)), closes [#1242](#1242) * return security group id for docker-autoscaler in `runner_sg_id` ([#1249](#1249)) ([9c573b6](9c573b6)), closes [#1241](#1241) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: cattle-ops-releaser-2[bot] <134548870+cattle-ops-releaser-2[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Remove
min_sizeandmax_sizefromignore_changesfrom the ASG for Docker Autoscaler. The reasoning described in the comment was poor; min_size is fixed at zero, so won't change, and max_size should change when runner_worker.max_jobs is changed, and will not cause immediate scale-up. If it causes scale-down, this the logical desired behaviour.