Skip to content

fix: add filter to s3 lifecycle rule #1264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 15, 2025

Conversation

a-moussaoui
Copy link
Contributor

@a-moussaoui a-moussaoui commented Mar 14, 2025

Description

Eliminates terraform warning: No attribute specified when one (and only one) of [rule[0].prefix.<.filter] is required

Closes #1263

Copy link
Contributor

Hey @a-moussaoui! 👋

Thank you for your contribution to the project. Please refer to the contribution rules for a quick overview of the process.

Make sure that this PR clearly explains:

  • the problem being solved
  • the best way a reviewer and you can test your changes

With submitting this PR you confirm that you hold the rights of the code added and agree that it will published under this LICENSE.

The following ChatOps commands are supported:

  • /help: notifies a maintainer to help you out

Simply add a comment with the command in the first line. If you need to pass more information, separate it with a blank line from the command.

This message was generated automatically. You are welcome to improve it.

@a-moussaoui a-moussaoui changed the title add filter to s3 lifecycle rule fix: add filter to s3 lifecycle rule Mar 14, 2025
Copy link
Collaborator

@kayman-mk kayman-mk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for quickly fixing this upcoming issue.

@kayman-mk kayman-mk merged commit c8180ba into cattle-ops:main Mar 15, 2025
19 checks passed
kayman-mk pushed a commit that referenced this pull request Mar 22, 2025
🤖 I have created a release *beep* *boop*
---


##
[9.2.0](9.1.1...9.2.0)
(2025-03-22)


### Features

* add instance requirements option for docker autoscaler asg
([#1262](#1262))
([84cbaf5](84cbaf5))


### Bug Fixes

* add filter to s3 lifecycle rule
([#1264](#1264))
([c8180ba](c8180ba))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: cattle-ops-releaser-2[bot] <134548870+cattle-ops-releaser-2[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing s3 lifecycle rule prefix
2 participants