fix: use IMDSv2 url when setting PARENT_INSTANCE_ID #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npalm
pushed a commit
that referenced
this pull request
May 26, 2022
semantic-releaser bot
pushed a commit
that referenced
this pull request
May 26, 2022
### [5.0.2](5.0.1...5.0.2) (2022-05-26) ### Bug Fixes * use IMDSv2 url when setting PARENT_INSTANCE_ID ([#497](#497)) ([536535f](536535f))
|
@snoord Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the URL used for the
PARENT_INSTANCE_IDvariable so that it now points to the AWS IMDSv2 endpoint.Using the old URL caused an empty
gitlab-runner-parent-idtag to be added to all runner instances created by agents, which broke the Lambda function for terminating stray runner instances.Closes #496
Migrations required
NO
Verification
Successfully tested in private AWS account.
Documentation
We use pre-commit to update the Terraform inputs and outputs in the documentation via terraform-docs. Ensure you have installed those components.