Skip to content

feat: Add tags parameter to aws_cloudwatch_event_rule resource + linting #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 20, 2022
Merged

feat: Add tags parameter to aws_cloudwatch_event_rule resource + linting #519

merged 1 commit into from
Jul 20, 2022

Conversation

aperigault
Copy link
Contributor

Description

aws_cloudwatch_event_rule is missing tags argument.
Others changes are related to tflint errors.

Migrations required

NO

@aperigault aperigault force-pushed the aws_cloudwatch_event_rule_tags branch from e3472a7 to 8448c5a Compare July 20, 2022 10:05
npalm
npalm approved these changes Jul 20, 2022
View reviewed changes
Copy link
Collaborator

@npalm npalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aperigault thx, LGTM

@npalm npalm merged commit f2e98bb into cattle-ops:develop Jul 20, 2022
semantic-releaser bot pushed a commit that referenced this pull request Jul 20, 2022
@semantic-release-bot
chore(release): 5.1.0 [skip ci]
8a7049a 
## [5.1.0](5.0.2...5.1.0) (2022-07-20)

### Features

* add `clone_url` to `config.toml` ([#516](#516)) ([9a41525](9a41525))
* Tag aws_cloudwatch_event_rule resource + linting ([#519](#519)) ([f2e98bb](f2e98bb))

### Bug Fixes

* Make statement IDs unique ([#503](#503)) ([05055c0](05055c0))
@semantic-releaser
Copy link
Contributor

🎉 This PR is included in version 5.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npalm npalm npalm approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aperigault @npalm