fix: Set pull_policy instead of allowed_pull_policies #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @cinacio. Looks good to me. |
|
Looks good to me as well. Supporting the |
npalm
approved these changes
Nov 27, 2022
semantic-releaser bot
pushed a commit
that referenced
this pull request
Nov 27, 2022
## [5.5.0](5.4.1...5.5.0) (2022-11-27) ### Features * Support volume type configuration ([#579](#579)) ([b7dd834](b7dd834)) ### Bug Fixes * Compress (zip) user_data to avoid max size ([#565](#565)) ([64b8594](64b8594)) * ensure a complete `config.toml` before starting the GitLab Agent ([#574](#574)) ([e32f3bc](e32f3bc)) * Use runners_pull_policies to set pull_policy instead of allowed_pull_policies ([#557](#557)) ([a67b87b](a67b87b))
|
🎉 This PR is included in version 5.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
npalm
pushed a commit
to npalm/test-repo
that referenced
this pull request
Dec 8, 2022
## [5.5.0](cattle-ops/terraform-aws-gitlab-runner@5.4.1...5.5.0) (2022-11-27) ### Features * Support volume type configuration ([#579](cattle-ops/terraform-aws-gitlab-runner#579)) ([b7dd834](cattle-ops/terraform-aws-gitlab-runner@b7dd834)) ### Bug Fixes * Compress (zip) user_data to avoid max size ([#565](cattle-ops/terraform-aws-gitlab-runner#565)) ([64b8594](cattle-ops/terraform-aws-gitlab-runner@64b8594)) * ensure a complete `config.toml` before starting the GitLab Agent ([#574](cattle-ops/terraform-aws-gitlab-runner#574)) ([e32f3bc](cattle-ops/terraform-aws-gitlab-runner@e32f3bc)) * Use runners_pull_policies to set pull_policy instead of allowed_pull_policies ([#557](cattle-ops/terraform-aws-gitlab-runner#557)) ([a67b87b](cattle-ops/terraform-aws-gitlab-runner@a67b87b))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since #544 was merged in,
runners_pull_policiesis used to set the runner'sallowed_pull_policiesinstead ofpull_policy. That is confusing, and it changes the behaviour of the directive and prevents setting the default pull policy for the runner.This change switches back to using
runners_pull_policiesto set the runner'spull_policy, while still allowing for multiple policies to be defined.Migrations required
NO
Verification
I have verified that the correct
pull_policydirective is now set on the runners.