Skip to content

ci: fix the TfDocs creation in feature branch #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 31, 2022

Conversation

kayman-mk
Copy link
Collaborator

@kayman-mk kayman-mk commented Dec 12, 2022

The workflow was not running in case the PR was created from a foreign repository. The checkout of the branch didn't succeed.

The TF docs are now generated in the release branch if a commit is pushed.

@kayman-mk kayman-mk force-pushed the kayma/fix-tf-docs-creation branch from be8afd0 to 9bcba31 Compare December 12, 2022 20:10
@kayman-mk
Copy link
Collaborator Author

@npalm Just noticed that the TfDocs creation in the feature branch is not working. Could you please have a look? Tried some fixes but they are not working.

First seen here: #517

npalm
npalm previously approved these changes Dec 12, 2022
@npalm
Copy link
Collaborator

npalm commented Dec 12, 2022

seems still failing

@kayman-mk
Copy link
Collaborator Author

Simply using a plain checkout does not work as it leaves the repository in a detached head state. But we need a branch to push a commit.

@npalm
Copy link
Collaborator

npalm commented Dec 13, 2022

I was thinking we can simply run the updates of the docs on the release branch, merging that branch is making the release.

@kayman-mk
Copy link
Collaborator Author

Let's give it a go. Better than now.

But the main branch is not always in a consistent state as the release might be done several days later.

@kayman-mk kayman-mk marked this pull request as ready for review December 23, 2022 17:04
@kayman-mk kayman-mk requested a review from npalm December 23, 2022 17:05
@kayman-mk
Copy link
Collaborator Author

@npalm This one should be ready now. Docs are created in the release branch as discussed.

@npalm npalm merged commit 88bb5d1 into cattle-ops:main Dec 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants