Skip to content

Add allErrors to validate request/response options #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 31, 2024

Conversation

mdmower-csnw
Copy link
Contributor

  • Include usage notes and schema for allErrors property in validateRequests and validateResponses.
  • Minor typo fixes.

- Include usage notes and schema for `allErrors` property in
  validateRequests and validateResponses.
- Minor typo fixes.
Copy link
Contributor Author

@mdmower-csnw mdmower-csnw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cdimascio - obviously, feel free to edit this PR as much as you like, but I specifically called out two lines that have versions which you should review and update as needed. Thanks!


- ### `allErrors`

> This option was introduced in version 5.4.0, where the default behavior of request validation was changed to stop after the first failure.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update version

- ### `allErrors`

> This option was introduced in version 5.4.0, where the default behavior of response validation was changed to stop after the first failure.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update version

@cdimascio cdimascio merged commit 1eaf078 into cdimascio:main Aug 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants