BUG: Failure during creation results in `Invalid PhysicalResourceId`

[cheruvian]

The deployment is written in such a way that it will return an undefined PhysicalResourceId which is invalid and results in that error being surfaced to CloudFormation obscuring the actual underlying issue.

It should be defaulted to a non-empty string on error (or always?)

FWIW, the correct underlying error is properly logged and does work if the CustomResource is being updated rather than created/replaced

e.g. error

2024/05/29 15:28:56 sending status failed: copy image failed: creating an updated image manifest: preparing updated manifest, layer "sha256:0fda6f180a9e87ea218f7415ac4a32316291a0f6a2e359367190781bf3642968": unsupported MIME type for compression: application/vnd.in-toto+json
--

Reported CF Error

Invalid PhysicalResourceId

Error location: https://github.com/cdklabs/cdk-ecr-deployment/blob/main/lambda/main.go#L114
PhsyicalResourceId definition: https://github.com/cdklabs/cdk-ecr-deployment/blob/main/lambda/main.go#L39

[bschulz87]

Adding the repository as a dependency to an image fixes the issue.

#283 (comment)

Update: Sorry, wrote too early. Having the repository as dependency still results in Invalid PhysicalResourceId error.

[tiagolisalves]

I was facing the same issue after using NO_PREBUILT_LAMBDA=1.

I placed --no-rollback on cdk deploy, when I got the error I went to Cloud Watch to see why. I saw this:

2025/01/16 14:36:40 sending status failed: copy image failed: writing blob: initiating layer upload to /v2/repository/blobs/uploads/ in '{account}'.dkr.ecr.sa-east-1.amazonaws.com: name unknown: The repository with name 'repository' does not exist in the registry with id '{account}'

To fix it I had to create the repository using aws-cdk-lib/aws-ecr before deploying:

const repo = new ecr.Repository(this, "EtlDwRepository", {
  repositoryName: "repository-name",
});

const image = new DockerImageAsset(this, "CDKDockerImage", {
  directory: path.join(__dirname, "..", "..", "src"),
});

new ecrdeploy.ECRDeployment(this, "DeployEtlDwDockerImage", {
  src: new ecrdeploy.DockerImageName(image.imageUri),
  dest: new ecrdeploy.DockerImageName(
    `${cdk.Aws.ACCOUNT_ID}.dkr.ecr.${cdk.Aws.REGION}.amazonaws.com/${repo.repositoryName}:latest`
   ),
});

[mrgrain]

This comes down to this: aws/aws-lambda-go#107