Skip to content

Make DAVerifier functions external instead of public #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
adlerjohn opened this issue Oct 18, 2023 · 3 comments · Fixed by #239
Closed

Make DAVerifier functions external instead of public #237

adlerjohn opened this issue Oct 18, 2023 · 3 comments · Fixed by #239
Assignees

Comments

@adlerjohn
Copy link
Member

verifyRowRootToDataRootTupleRoot and verifyMultiRowRootsToDataRootTupleRoot are public, when they can be external.

@adlerjohn
Copy link
Member Author

Actually, this brings up a question of if the library should only have internal functions or some external functions. If the former, then it can be compiled inline and reduce gas costs in some cases at higher deploy cost.

@rach-id
Copy link
Member

rach-id commented Oct 18, 2023

I think internal makes more sense since rollups will be using their contracts for verification instead of calling external ones. So it makes sense to make them internal

@Ferret-san
Copy link

From talking to rollup teams, they generally prefer internal libraries when there's contract space for it. And usually there's space for it in the contracts where the libraries would be used.

@rach-id rach-id self-assigned this Oct 19, 2023
@rach-id rach-id moved this to In Review in core/app Oct 19, 2023
rach-id added a commit that referenced this issue Oct 19, 2023
<!--
Please read and fill out this form before submitting your PR.

Please make sure you have reviewed our contributors guide before
submitting your
first PR.
-->

## Overview

Closes #237

## Checklist

<!-- 
Please complete the checklist to ensure that the PR is ready to be
reviewed.

IMPORTANT:
PRs should be left in Draft until the below checklist is completed.
-->

- [ ] New and updated code has appropriate documentation
- [ ] New and updated code has new and/or updated testing
- [ ] Required CI checks are passing
- [ ] Visual proof for any user facing features like CLI or
documentation updates
- [ ] Linked issues closed with keywords
@github-project-automation github-project-automation bot moved this from In Review to Done in core/app Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants