Skip to content

Separate proof verification from contract verification #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rach-id opened this issue Jan 26, 2024 · 0 comments · Fixed by #286
Closed

Separate proof verification from contract verification #285

rach-id opened this issue Jan 26, 2024 · 0 comments · Fixed by #286
Assignees
@rach-id
Labels
contracts

Comments

@rach-id
Copy link
Member

rach-id commented Jan 26, 2024

We should separate proof verification from the contract calls to authenticate proofs in DAVerifier.
@rach-id rach-id self-assigned this Jan 26, 2024
@rach-id rach-id added this to core/app Jan 26, 2024
@github-project-automation github-project-automation bot moved this to Todo in core/app Jan 26, 2024
@rach-id rach-id moved this from Todo to In Review in core/app Jan 29, 2024
@rach-id rach-id mentioned this issue Jan 29, 2024
Merged
5 tasks
rach-id added a commit that referenced this issue Feb 23, 2024
@rach-id
refactor: expose pure functions in DAVerifier (#286)
4f27c20 
<!--
Please read and fill out this form before submitting your PR.

Please make sure you have reviewed our contributors guide before
submitting your
first PR.
-->

## Overview

Closes #285

## Checklist

<!-- 
Please complete the checklist to ensure that the PR is ready to be
reviewed.

IMPORTANT:
PRs should be left in Draft until the below checklist is completed.
-->

- [ ] New and updated code has appropriate documentation
- [ ] New and updated code has new and/or updated testing
- [ ] Required CI checks are passing
- [ ] Visual proof for any user facing features like CLI or
documentation updates
- [ ] Linked issues closed with keywords


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Refactor**
- Improved the internal verification process for data proofs, enhancing
the consistency and reliability of data verification.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@github-project-automation github-project-automation bot moved this from In Review to Done in core/app Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rach-id rach-id

Labels
contracts
Projects
core/app
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: expose pure functions in DAVerifier rach-id/quantum-gravity-bridge
1 participant
@rach-id